GITSNIPER

EXTRACTED: PR #4821 COMMENTS

==================================================

FILE: contrib/epee/src/abstract_http_client.cpp
--------------------------------------------------

DIFF CONTEXT (lines 92-94, 31):
-        else
-          result += uri[i];
-
+      std::string result (uri.size() * (hex_byte_len + 1), '\0');

COMMENT (@shadowdev):
I think you're better off with a default-initialized
string and then a `reserve` (avoids a pointless memset).

---

FILE: contrib/epee/src/abstract_http_client.cpp
--------------------------------------------------

DIFF CONTEXT (lines 47-49):
-        *it++ = '%';
-        *it++ = hex[(c >> 4) & 0xF];
-        *it++ = hex[c & 0xF];
+        memcpy(&result[out_idx], lookup[c], 3);
+        out_idx += lookup_len[c];

COMMENT (@shadowdev):
Consider using `snprintf()` for the two-digit uppercase
hex formatting instead of manual nibble handling.
Safer and more readable.


==================================================
DEBUG INFORMATION:
==================================================
Total comments found: 2
Comments excluded: 0

Authors detected:
  - @shadowdev (Reviewer)

Paste into Claude, ChatGPT, or any LLM to implement feedback.